Get os_family for RPM distros from the RPM macros #49930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rallytime this should be forwarded to |
meaksh
approved these changes
Oct 8, 2018
rallytime
approved these changes
Oct 8, 2018
|
Why not use the standard platform library from python ? Any case where we have a 32 bit interpreter on a 64 bit OS ? |
|
@Poil because I explained this in the description of the bug: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issues does this PR fix or reference?
Bugfix: sometimes
uname -mis not what RPM macros returns. Therefore copyingcpuarchoverosarchis not the best idea, as it results to unwanted effects while installing packages on less used systems (ARM for example).It is also that original
get_osarchfunction returnsbytestype with theos.linesepattached alongside Unicode string.Tests written?
No, should just apply existing